Skip to content

fix: remove just-debounce-it #9707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 18, 2023
Merged

fix: remove just-debounce-it #9707

merged 5 commits into from
Sep 18, 2023

Conversation

Parkreiner
Copy link
Member

@Parkreiner Parkreiner commented Sep 15, 2023

Closes #9706
Very tiny PR.

It removes all instances of the just-debounce-it library (and uninstalls it), replacing the previous calls with the new in-house useDebouncedFunction hook.

@Parkreiner
Copy link
Member Author

Parkreiner commented Sep 15, 2023

I want to say this is good to go, but I'm going to do some extra testing before marking it as ready.

It looked like the two components that needed the swaps were uncontrolled input elements, but I then realized that they were using the render props pattern and had some indirect inputs.

@Parkreiner Parkreiner changed the title fix: Remove just-debounce-it fix: remove just-debounce-it Sep 15, 2023
@Parkreiner
Copy link
Member Author

Double-checked everything – weirdly enough, it seems that the previous code might not have had the chance to cause any problems, even though the debounce functions would get re-declared each render.

It seems the reason why the issue was so much more pronounced for the Workspaces view was because the Workspaces page was re-polling every five seconds, so the debounce function there was getting rebuilt far more frequently.

@Parkreiner Parkreiner marked this pull request as ready for review September 18, 2023 14:08
@Parkreiner Parkreiner enabled auto-merge (squash) September 18, 2023 14:11
@Parkreiner Parkreiner disabled auto-merge September 18, 2023 14:11
@Parkreiner Parkreiner enabled auto-merge (squash) September 18, 2023 14:11
@Parkreiner Parkreiner merged commit 2caf7a7 into main Sep 18, 2023
@Parkreiner Parkreiner deleted the debounce-fix branch September 18, 2023 14:20
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

site: Remove just-debounce-it from all React renders
2 participants