Skip to content

feat: show version messages in version lists #9708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 18, 2023
Merged

feat: show version messages in version lists #9708

merged 4 commits into from
Sep 18, 2023

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Sep 15, 2023

Another part of #8657

Screenshot 2023-09-15 at 2 50 28 PM Screenshot 2023-09-15 at 1 23 59 PM
  • Show a little help hint on the template versions page, which you can hover to see the message
  • Show an info icon on versions with a message in the "change version" dialog, and display the message when selected

@BrunoQuaresma
Copy link
Collaborator

Notes about the screenshot you posted:

  • The select left margin looks "not right"
  • What do you think about showing a yellow info icon we show a white message - chat balloon - icon?

BrunoQuaresma
BrunoQuaresma approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment about minor UI things

@aslilac
Copy link
Member Author

aslilac commented Sep 18, 2023

Notes about the screenshot you posted:

  • The select left margin looks "not right"
  • What do you think about showing a yellow info icon we show a white message - chat balloon - icon?

yeah, it definitely doesn't. I should touch that up while I'm in here.

we already use the info icon for very similar popups in other places in the app. also the screenshot is out of date, I already changed the color. :)

@aslilac aslilac merged commit f85aa44 into main Sep 18, 2023
@aslilac aslilac deleted the version-info-tooltip branch September 18, 2023 17:17
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2023
@aslilac aslilac linked an issue Sep 22, 2023 that may be closed by this pull request
Add template version messages to the rest of the product #8657
Closed
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

Assignees

@aslilac aslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add template version messages to the rest of the product
2 participants
@aslilac @BrunoQuaresma