Skip to content

ci: Add timeouts to limit hanging execution #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2022
Merged

ci: Add timeouts to limit hanging execution #976

merged 1 commit into from
Apr 12, 2022

Conversation

kylecarbs
Copy link
Member

For some reason, CI hung for ~6hours last night on main.

https://github.com/coder/coder/runs/5982978236?check_suite_focus=true

The fact that it went this long is bad, but it should have cancelled
much earlier.

For some reason, CI hung for ~6hours last night on `main`.

https://github.com/coder/coder/runs/5982978236?check_suite_focus=true

The fact that it went this long is bad, but it should have cancelled
much earlier.
@kylecarbs kylecarbs requested a review from Emyrk April 12, 2022 13:54
@kylecarbs kylecarbs self-assigned this Apr 12, 2022
@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #976 (2d711e1) into main (db9d5b7) will decrease coverage by 0.56%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #976      +/-   ##
==========================================
- Coverage   67.05%   66.48%   -0.57%     
==========================================
  Files         241      241              
  Lines       14577    14577              
  Branches      115      115              
==========================================
- Hits         9774     9692      -82     
- Misses       3833     3895      +62     
- Partials      970      990      +20     
Flag Coverage Δ
unittest-go-macos-latest 53.59% <ø> (-0.19%) ⬇️
unittest-go-postgres- 66.13% <ø> (-0.68%) ⬇️
unittest-go-ubuntu-latest 56.17% <ø> (-0.25%) ⬇️
unittest-go-windows-2022 53.01% <ø> (-0.11%) ⬇️
unittest-js 61.56% <ø> (ø)
Impacted Files Coverage Δ
provisionersdk/serve.go 35.13% <0.00%> (-8.11%) ⬇️
coderd/parameter/compute.go 74.07% <0.00%> (-6.67%) ⬇️
peerbroker/dial.go 77.04% <0.00%> (-6.56%) ⬇️
coderd/provisionerdaemons.go 59.45% <0.00%> (-4.06%) ⬇️
peer/conn.go 78.42% <0.00%> (-3.30%) ⬇️
provisionerd/provisionerd.go 80.58% <0.00%> (-2.50%) ⬇️
provisioner/echo/serve.go 56.80% <0.00%> (-2.41%) ⬇️
peer/channel.go 83.23% <0.00%> (-0.58%) ⬇️
provisioner/terraform/provision.go 68.11% <0.00%> (-0.44%) ⬇️
coderd/database/queries.sql.go 83.46% <0.00%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db9d5b7...2d711e1. Read the comment docs.

@kylecarbs kylecarbs merged commit 4f0f216 into main Apr 12, 2022
@kylecarbs kylecarbs deleted the timeouts branch April 12, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants