Skip to content

test(cli): ensure first option selected with is expected #9770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 19, 2023
Merged

test(cli): ensure first option selected with is expected #9770

merged 3 commits into from
Sep 19, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Sep 19, 2023

Fixes: #9748

This PR fine-tunes the CLI test to prevent flakiness.

Major changes:

  • Wait for CLI commands to finish
  • Re-arrange Rich Parameter options to be compliant with cliui.Select limitation

@mtojek mtojek marked this pull request as ready for review September 19, 2023 08:54
@mtojek mtojek requested a review from spikecurtis September 19, 2023 08:54
@spikecurtis
Copy link
Contributor

I think these tests each need comments explaining the options order and the limitation that our pty + cliui selects the first option.

@mtojek
Copy link
Member Author

mtojek commented Sep 19, 2023

I think these tests each need comments explaining the options order and the limitation that our pty + cliui selects the first option.

Done

@mtojek mtojek merged commit ceeb998 into main Sep 19, 2023
@mtojek mtojek deleted the 9748-changed branch September 19, 2023 11:55
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@spikecurtis spikecurtis spikecurtis approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test flake: TestUpdateValidateRichParameters/ParameterOptionChanged
2 participants
@mtojek @spikecurtis