Skip to content

chore: remove extra condition from pr-deploy.yaml #9788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Sep 21, 2023
Merged

chore: remove extra condition from pr-deploy.yaml #9788

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
9707a46
chore: remove extra condition from pr-deploy.yaml
matifali Sep 20, 2023
b4081be
add debug info
matifali Sep 21, 2023
e0cf938
debug
matifali Sep 21, 2023
a3fbdad
test
matifali Sep 21, 2023
790b96b
test gain
matifali Sep 21, 2023
44ac8f3
Merge branch 'main' into deploy-pr-touchup
matifali Sep 21, 2023
a2081ee
more debugging
matifali Sep 21, 2023
b214a53
revert back condition
matifali Sep 21, 2023
b84d5ea
test build
matifali Sep 21, 2023
475e132
try treating values as string
matifali Sep 21, 2023
e29f002
Discard changes to go.mod
matifali Sep 21, 2023
f386218
Discard changes to go.sum
matifali Sep 21, 2023
80a483f
remove debug step
matifali Sep 21, 2023
470aac8
try moving concurrency to build job
matifali Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/pr-deploy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,6 @@ permissions:
packages: write
pull-requests: write # needed for commenting on PRs

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
check_pr:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -73,7 +69,7 @@ jobs:
CODER_BASE_IMAGE_TAG: ${{ steps.set_tags.outputs.CODER_BASE_IMAGE_TAG }}
CODER_IMAGE_TAG: ${{ steps.set_tags.outputs.CODER_IMAGE_TAG }}
NEW: ${{ steps.check_deployment.outputs.NEW }}
BUILD: ${{ steps.build_conditionals.outputs.first_or_force_build || steps.build_conditionals.outputs.automatic_rebuild }}
BUILD: ${{ steps.build_conditionals.outputs.first_or_force_build == 'true' || steps.build_conditionals.outputs.automatic_rebuild == 'true' }}

runs-on: "ubuntu-latest"
steps:
Expand Down Expand Up @@ -166,7 +162,7 @@ jobs:
echo "automatic_rebuild=${{ steps.check_deployment.outputs.NEW == 'false' && steps.filter.outputs.all_count > steps.filter.outputs.ignored_count }}" >> $GITHUB_OUTPUT

comment-pr:
needs: [check_pr, get_info]
needs: get_info
if: needs.get_info.outputs.BUILD == 'true' || github.event.inputs.deploy == 'true'
runs-on: "ubuntu-latest"
steps:
Expand Down Expand Up @@ -198,6 +194,10 @@ jobs:
# Run build job only if there are changes in the files that we care about or if the workflow is manually triggered with --build flag
if: needs.get_info.outputs.BUILD == 'true'
runs-on: ${{ github.repository_owner == 'coder' && 'buildjet-8vcpu-ubuntu-2204' || 'ubuntu-latest' }}
# This concurrency only cancels build jobs if a new build is triggred. It will avoid cancelling the current deployemtn in case of docs chnages.
concurrency:
group: build-${{ github.workflow }}-${{ github.ref }}-${{ needs.get_info.outputs.BUILD }}
cancel-in-progress: true
env:
DOCKER_CLI_EXPERIMENTAL: "enabled"
CODER_IMAGE_TAG: ${{ needs.get_info.outputs.CODER_IMAGE_TAG }}
Expand Down