fix: call agent directly in cli tests #9789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spike Curtis <spike@coder.com>
Signed-off-by: Spike Curtis <spike@coder.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests like TestDERPHeaders create an agent, and then run a CLI command that communicates with it.
Prior to this change, we used the CLI itself to start the agent. This
a) is needlessly complicated as it interjects the cli-invocation and pseudoterminal packages
b) makes it impossible to tell which logs came from the agent and which from the CLI command under test, since they both get generically logged by the ptytest package. c.f. https://github.com/coder/coder/actions/runs/6221630697/job/16883998408?pr=9717
So instead, we just start the agent directly with a named logger.
I also start the CLI command under test in TestDERPHeaders with
-vso that we get debug logs from it.