Skip to content

test(site): workaround for reattached xterm-rows #9790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Sep 20, 2023

Spotted in: https://github.com/coder/coder/actions/runs/6236909229

This PR adds an extra timeout in the middle of webTerminal test. Apparently, xterm-rows div is being recreated and reattached, so we can't do a proper assertion on the executed command.

@mtojek mtojek self-assigned this Sep 20, 2023
@mtojek mtojek marked this pull request as ready for review September 20, 2023 12:11
@mtojek mtojek merged commit 8e012e4 into main Sep 20, 2023
@mtojek mtojek deleted the e2e-delay-the-terminal branch September 20, 2023 12:25
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants