Skip to content

test(site): fix terminal page test flakiness #9798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 20, 2023
Merged

test(site): fix terminal page test flakiness #9798

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42886af
Fix connection warning
BrunoQuaresma Sep 20, 2023
d922a56
Fix connection close
BrunoQuaresma Sep 20, 2023
66cdb3d
Increase timeout for terminal
BrunoQuaresma Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix connection close
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Sep 20, 2023
commit d922a56752ccb743c2854afa697ed5e23250c6e4
3 changes: 2 additions & 1 deletion site/src/pages/TerminalPage/TerminalPage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ describe("TerminalPage", () => {
const spy = jest
.spyOn(API, "getWorkspaceByOwnerAndName")
.mockResolvedValue(MockWorkspace);
new WS(
const ws = new WS(
`ws://localhost/api/v2/workspaceagents/${MockWorkspaceAgent.id}/pty`,
);
await renderTerminal(
Expand All @@ -80,6 +80,7 @@ describe("TerminalPage", () => {
);
});
spy.mockRestore();
ws.close();
});

it("shows an error if fetching workspace fails", async () => {
Expand Down