feat: expose insights into user activity #9807
Conversation
coderd/database/queries/insights.sql
Outdated
| template_id, | ||
| start_time, | ||
| seconds | ||
| FROM combined_stats |
There was a problem hiding this comment.
You could remove this additional step if you change UNION ALL to UNION above, it'll remove duplicates.
However, in this instance I'm not sure if we should sum template IDs separately. Say you use template A and B concurrently for 1h, you will be listed as 2h in the stats now. Perhaps instead we should modify this distinct to be a group by (user, start time) with array_agg on the templates. Not sure about this, but putting it out there...
There was a problem hiding this comment.
You could remove this additional step if you change UNION ALL to UNION above, it'll remove duplicates.
Done! Thanks for the suggestion.
Say you use template A and B concurrently for 1h, you will be listed as 2h in the stats now.
It might be a business question, as it indicates the total duration the user spent working with the specific template. I would rather keep it as is rather than "online presence". Anyway, I will describe and cover it with tests 👍
|
@mafredri Let's start the next review round. I implemented the entire workflow and covered responses with golden files. My biggest concern is
|
| "user_id": "00000000-0000-0000-0000-000000000004", | ||
| "username": "user1", | ||
| "avatar_url": "", | ||
| "seconds": 32400 |
There was a problem hiding this comment.
Note-to-self: At first I thought this looked off, comparing the template golden file for the same setup, but upon verifying with the data it looks good, there is indeed 9h of distinct usage. 👍🏻
| "user_id": "00000000-0000-0000-0000-000000000004", | ||
| "username": "user1", | ||
| "avatar_url": "", | ||
| "seconds": 30540 |
There was a problem hiding this comment.
Note-to-self: Also verified this number, 1h is lost from users[0].workspaces[1] due to timeframe and all the minute intervals are summed from users[0].workspaces[0] giving us 8h + 29m. The hours in u0w0 overlap with u0w1 so we don't see an increase from those.
Related: #9497
This PR extends Insights API with the user activity. BTW I moved golden files for
TestTemplateInsights_Goldento a dedicated subdirectory.Note: I know that this PR is large, mainly due to generated golden files. I'm happy to split the PR into pieces if it helps!
TODO: