Skip to content

fix: use AlwaysEnable for licenses with all features #9808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

spikecurtis
Copy link
Contributor

Fixes an issue where if you have a license for all features, it doesn't enable features with AlwaysEnable() == true

Also fixes an issue where we would set all features to entitled, even with a license in grace period.

Signed-off-by: Spike Curtis <spike@coder.com>
JWT: coderdenttest.GenerateLicense(t, coderdenttest.LicenseOptions{
AllFeatures: true,
GraceAt: time.Now().Add(-time.Hour),
ExpiresAt: time.Now().Add(time.Hour),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dbtime.Now

@matifali
Copy link
Member

@BrunoQuaresma, I guess this will solve the workspace batch deletion feature not appearing.

Signed-off-by: Spike Curtis <spike@coder.com>
@spikecurtis spikecurtis enabled auto-merge (squash) September 22, 2023 04:56
@spikecurtis spikecurtis merged commit e9077f3 into main Sep 22, 2023
@spikecurtis spikecurtis deleted the spike/fix-feature-always-enabled branch September 22, 2023 05:02
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants