chore(site): replace setup machine by react-query #9809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parkreiner
approved these changes
Sep 21, 2023
| isLoading={createFirstUserMutation.isLoading} | ||
| error={createFirstUserMutation.error} | ||
| onSubmit={async (firstUser) => { | ||
| await createFirstUserMutation.mutateAsync(firstUser); |
There was a problem hiding this comment.
Forgot to ask earlier, but how has Coder generally approached error handling before? I checked the App.tsx file and didn't see a global error handler for the query client/cache, so I wasn't sure where/how we generally try to address errors
There was a problem hiding this comment.
Assuming error handling is taken care of, this looks good to me! Going to approve, just to avoid blocking you
There was a problem hiding this comment.
We don't have anything specifically but it depends if it is a form, a "display" page, or a standalone action.
- Form forms, we get the error and pass down to the form component
- For pages that show something we use an or a custom if you need it
- For standalone actions like remove user, we use the displayError()
|
Related to #9598 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.