feat(site): Read users into basic UsersTable #981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #981 +/- ##
==========================================
+ Coverage 66.62% 66.72% +0.10%
==========================================
Files 249 255 +6
Lines 14686 14915 +229
Branches 135 136 +1
==========================================
+ Hits 9784 9952 +168
- Misses 3923 3964 +41
- Partials 979 999 +20
Continue to review full report at Codecov.
|
greyscaled
reviewed
Apr 14, 2022
greyscaled
approved these changes
Apr 14, 2022
There was a problem hiding this comment.
Approving with the suggestion and merge 🎉. I know it's listed as a merge conflict, but I ran it locally and it was a case of "yes I want both of these changes":
export interface Pager {
total: number
}
export interface PagedUsers {
page: UserResponse[]
pager: Pager
}
export interface WorkspaceAutostartRequest {
schedule: string
}
export interface WorkspaceAutostopRequest {
schedule: string
}I'm not sure why this is registering as a conflict, but I digress.
Awesome stuff!!
Co-authored-by: G r e y <grey@coder.com>
…o users-table/presleyp/592
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AC:
The other columns and pagination will be done separately.