Skip to content

docs: update VS Code Web docs #9811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
docs: update VS Code Web docs
  • Loading branch information
matifali authored Sep 21, 2023
commit cf22b74b2c9b4267cc1d51ec9923003b14da3015
26 changes: 10 additions & 16 deletions docs/ides/web-ides.md
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ resource "coder_app" "code-server" {
display_name = "code-server"
url = "http://localhost:13337/?folder=/home/coder"
icon = "/icon/code.svg"
subdomain = true
subdomain = false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do not need subdomain = true for code-server


healthcheck {
url = "http://localhost:13337/healthz"
Expand Down Expand Up @@ -159,21 +159,15 @@ resource "coder_agent" "main" {
You also need to add a `coder_app` resource for this.

```hcl
# VS Code Server
resource "coder_app" "vscode-server" {
agent_id = coder_agent.coder.id
slug = "vscode-server"
display_name = "VS Code Server"
icon = "/icon/code.svg"
url = "http://localhost:13338?folder=/home/coder"
subdomain = false
share = "owner"

healthcheck {
url = "http://localhost:13338/healthz"
interval = 3
threshold = 10
}
# VS Code Web
resource "coder_app" "vscode-web" {
agent_id = coder_agent.coder.id
slug = "vscode-web"
display_name = "VS Code Web"
icon = "/icon/code.svg"
url = "http://localhost:13338
subdomain = true # VS Code Web does currently does not work with a subpath https://github.com/microsoft/vscode/issues/192947
share = "owner"
}
```

Expand Down