chore(site): replace agent log service #9814
Conversation
|
|
||
| socket.current = API.watchWorkspaceAgentLogs(agentId, { | ||
| // Get all logs | ||
| after: 0, |
There was a problem hiding this comment.
We should not be using after: 0 all the time.
We intentionally have an endpoint to fetch all logs, and then we should stream afterward, just like before. This hopefully would reduce lagging/flickering on the UI as logs stream in from the WS, because they'd be delivered in a payload first.
There was a problem hiding this comment.
Hm.. I found having this way faster and better since we don't have to do two operations. It is also easy to understand. In this case, there is no lagging or flickering since when using after 0, all the "past" logs are being sent at once and not one by one.
There was a problem hiding this comment.
Pinging @kylecarbs in case he still feels strongly about the after property, but everything else looked good to me
…-agent-logs-service
|
Related to #9598 |
No description provided.