Skip to content

feat: add empty state for SSO auth methods #9818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 22, 2023
Merged

feat: add empty state for SSO auth methods #9818

merged 4 commits into from
Sep 22, 2023

Conversation

Parkreiner
Copy link
Member

@Parkreiner Parkreiner commented Sep 21, 2023 •
edited
Loading

Closes #9444

Pretty small PR. If the timestamps on the commits looks funny, it's because I had some Git branch issues I had to figure out.

Changes

  • Added an empty state for the list of auth methods in the event that the user is using a password but doesn't have any auth methods enabled
  • Removes some needless undefined checks
  • Updates some of the OIDC functions/components to take only the OIDC auth method as input, rather than the entire auth methods object

Notes

  • Would definitely appreciate any feedback on the styling, or even just how I had MUI set up

@Parkreiner Parkreiner requested review from a team and BrunoQuaresma and removed request for a team September 21, 2023 22:20
@Parkreiner Parkreiner marked this pull request as ready for review September 21, 2023 22:20
@Parkreiner Parkreiner changed the title feat: add empty state for auth methods feat: add empty state for SSO auth methods Sep 21, 2023
@Parkreiner
Copy link
Member Author

Visual preview of the changes:
Screenshot 2023-09-21 at 5 11 37 PM

BrunoQuaresma
BrunoQuaresma approved these changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Parkreiner Parkreiner merged commit 84999cb into main Sep 22, 2023
@Parkreiner Parkreiner deleted the mes/sso-empty-state branch September 22, 2023 13:38
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

Assignees

@Parkreiner Parkreiner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide SSO section account settings if no providers are configured
2 participants
@Parkreiner @BrunoQuaresma