Skip to content

fix: Multiple builds using the incorrect agent token #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 12, 2022
Merged

fix: Multiple builds using the incorrect agent token #983

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96b068b
fix: Multiple builds using the incorrect agent token
kylecarbs Apr 12, 2022
bede39d
Merge branch 'main' into multibuild
kylecarbs Apr 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion coderd/database/databasefake/databasefake.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,7 +626,9 @@ func (q *fakeQuerier) GetWorkspaceAgentByAuthToken(_ context.Context, authToken
q.mutex.RLock()
defer q.mutex.RUnlock()

for _, agent := range q.provisionerJobAgent {
// The schema sorts this by created at, so we iterate the array backwards.
for i := len(q.provisionerJobAgent) - 1; i >= 0; i-- {
agent := q.provisionerJobAgent[i]
if agent.AuthToken.String() == authToken.String() {
return agent, nil
}
Expand Down