Skip to content

chore(site): remove dead code #9830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 26, 2023
Merged

chore(site): remove dead code #9830

merged 3 commits into from
Sep 26, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

No description provided.

@BrunoQuaresma BrunoQuaresma requested a review from a team September 22, 2023 19:23
@BrunoQuaresma BrunoQuaresma self-assigned this Sep 22, 2023
@BrunoQuaresma BrunoQuaresma requested review from code-asher and removed request for a team September 22, 2023 19:23
@BrunoQuaresma
Copy link
Collaborator Author

Close #9599

code-asher
code-asher approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The best kind of PR! Not sure about ts-proto but the rest looks good to me.

@code-asher
Copy link
Member

I think maybe the lockfile is supposed to be generated by pnpm instead of regular npm? Not exactly sure but CI is saying:

ERR_PNPM_OUTDATED_LOCKFILE  Cannot install with "frozen-lockfile" because pnpm-lock.yaml is not up to date with package.json

@mtojek mtojek self-requested a review September 26, 2023 11:01
mtojek
mtojek reviewed Sep 26, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The best kind of PR! Not sure about ts-proto but the rest looks good to me.

FTR ts-proto is used by gen:provisioner to generate the provisioner stub. The imports from stub are used to build "echo" supported templates. Link

@BrunoQuaresma BrunoQuaresma merged commit b0b9d32 into main Sep 26, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/remove-dead-code branch September 26, 2023 13:05
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtojek mtojek mtojek left review comments

@code-asher code-asher Awaiting requested review from code-asher

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrunoQuaresma @code-asher @mtojek