-
Notifications
You must be signed in to change notification settings - Fork 881
fix: give more room to lonely resource metadata items #9832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I like how you resolved the issue if there is only a single item. I have 1 question/suggesion. |
To get the width in a way that would inspire any confidence, you'd have to just render it to the screen and ask the browser, which would result in flashing |
@aslilac it would flash only once. And we plan to do this for data that is dynamic so naturally keeps flashing |
}, | ||
}; | ||
|
||
function getAgentRow(agent: WorkspaceAgent): JSX.Element { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not create a component instead of having a getAgentRow
? ExampleAgentRow
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idk, this is just the way that it's already set up. 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it is an improvement, I'm good with it 👍
Closes #8887
Not perfect, but it's simple.
We can continue to iterate on this further, because it's still far from perfect in a lot of scenarios, but this at least improves one concrete use case, and gives us a thorough set of test-cases to base future work on.