Skip to content

feat: add middle click support for workspace rows #9834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 25, 2023
Merged

feat: add middle click support for workspace rows #9834

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0d88324
chore: add generic ref support for useClickable
Parkreiner Sep 22, 2023
0f62934
chore: update useClickable call sites to use type parameter
Parkreiner Sep 22, 2023
f90d9ff
chore: update useClickableTableRow implementation
Parkreiner Sep 22, 2023
bd42004
chore: update other components using useClickableTableRow
Parkreiner Sep 22, 2023
6535545
feat: add middle-click and cmd-click support for rows
Parkreiner Sep 22, 2023
78709a0
refactor: rename variable for clarity
Parkreiner Sep 22, 2023
486313e
docs: add comment for clarity
Parkreiner Sep 22, 2023
04c1b5d
chore: add more click logic and comments
Parkreiner Sep 23, 2023
c86b6e8
refactor: clean up useClickableTableRow
Parkreiner Sep 24, 2023
8ce3b5c
docs: rewrite comments for clarity
Parkreiner Sep 24, 2023
c7e1603
fix: update TimelineEntry to accept forwarded ref
Parkreiner Sep 25, 2023
ae68995
fix: fix keyboard event logic to respond to spaces properly
Parkreiner Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: update useClickable call sites to use type parameter
  • Loading branch information
@Parkreiner
Parkreiner committed Sep 22, 2023
commit 0f629342a386a269a2a7fee1776371a2c963c28b
2 changes: 1 addition & 1 deletion site/src/components/CopyableValue/CopyableValue.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export const CopyableValue: FC<CopyableValueProps> = ({
...props
}) => {
const { isCopied, copy } = useClipboard(value);
const clickableProps = useClickable(copy);
const clickableProps = useClickable<HTMLSpanElement>(copy);
const styles = useStyles();

return (
Expand Down
3 changes: 2 additions & 1 deletion site/src/components/FileUpload/FileUpload.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@ export const FileUpload: FC<FileUploadProps> = ({
const styles = useStyles();
const inputRef = useRef<HTMLInputElement>(null);
const tarDrop = useFileDrop(onUpload, fileTypeRequired);
const clickable = useClickable(() => {

const clickable = useClickable<HTMLDivElement>(() => {
if (inputRef.current) {
inputRef.current.click();
}
Expand Down
2 changes: 1 addition & 1 deletion site/src/pages/WorkspacePage/BuildRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export const BuildRow: React.FC<BuildRowProps> = ({ build }) => {
const styles = useStyles();
const initiatedBy = getDisplayWorkspaceBuildInitiatedBy(build);
const navigate = useNavigate();
const clickableProps = useClickable(() =>
const clickableProps = useClickable<HTMLTableRowElement>(() =>
navigate(`builds/${build.build_number}`),
);

Expand Down