Skip to content

chore: Add alias coder agent #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 13, 2022
Merged

chore: Add alias coder agent #986

merged 4 commits into from
Apr 13, 2022

Conversation

f0ssel
Copy link
Contributor

@f0ssel f0ssel commented Apr 12, 2022

No description provided.

@f0ssel f0ssel requested a review from kylecarbs April 12, 2022 22:10
@f0ssel f0ssel force-pushed the f0ssel/agent-alias branch from 595cb66 to 7dd7e08 Compare April 12, 2022 22:11
@f0ssel f0ssel changed the title Add alias coder agent chore: Add alias coder agent Apr 12, 2022
@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #986 (e1c5afb) into main (ce49966) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #986      +/-   ##
==========================================
- Coverage   66.53%   66.42%   -0.11%     
==========================================
  Files         240      237       -3     
  Lines       14588    14404     -184     
  Branches      115      115              
==========================================
- Hits         9706     9568     -138     
+ Misses       3892     3864      -28     
+ Partials      990      972      -18     
Flag Coverage Δ
unittest-go-macos-latest 53.57% <100.00%> (+0.09%) ⬆️
unittest-go-postgres- 66.41% <100.00%> (+0.12%) ⬆️
unittest-go-ubuntu-latest 55.97% <100.00%> (-0.18%) ⬇️
unittest-go-windows-2022 ?
unittest-js 61.56% <ø> (ø)
Impacted Files Coverage Δ
cli/agent.go 76.08% <ø> (ø)
cli/workspaces.go 53.12% <ø> (-1.43%) ⬇️
provisionersdk/agent.go 100.00% <ø> (ø)
cli/root.go 77.27% <100.00%> (+0.20%) ⬆️
cli/configssh.go 61.41% <0.00%> (-7.09%) ⬇️
pty/ptytest/ptytest.go 89.65% <0.00%> (-5.18%) ⬇️
cli/templateinit.go 58.62% <0.00%> (-3.45%) ⬇️
peerbroker/listen.go 84.16% <0.00%> (-3.34%) ⬇️
peer/conn.go 77.41% <0.00%> (-1.53%) ⬇️
peer/channel.go 84.97% <0.00%> (-0.58%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce49966...e1c5afb. Read the comment docs.

Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move the command instead? I think it's weird to alias a hidden command anyways.

@f0ssel
Copy link
Contributor Author

f0ssel commented Apr 13, 2022

@kylecarbs I couldn't find any more references to calling coder workspace agent in the repo, but I assume there's one somewhere for the terraform. Is there a place I'm probably missing?

@kylecarbs
Copy link
Member

provisionersdk/agent.go just has em!

Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should prob rename the file to agent too for consistency, but LGTM!

@f0ssel f0ssel enabled auto-merge (squash) April 13, 2022 20:50
@f0ssel f0ssel merged commit 027d89d into main Apr 13, 2022
@f0ssel f0ssel deleted the f0ssel/agent-alias branch April 13, 2022 20:55
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants