Skip to content

chore(scaletest): update scaletest terraform to match big.cdr.dev #9860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 27, 2023
Merged

chore(scaletest): update scaletest terraform to match big.cdr.dev #9860

merged 7 commits into from
Sep 27, 2023

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Sep 25, 2023 •
edited
Loading

Relates to #9568

This is the result of importing all existing resources to tfstate, editing tf, and running terraform plan until convergence.

  • Removes usage of null_resources as no longer required
  • Updates terraform in both infra/ and k8s/ to match
  • Updates provisionerd deployment to use helm chart

Note: I have not yet added the following:

  • cert-manager
  • otel collector
  • scaletest runner template

These will be added in subsequent PRs.

@johnstcn johnstcn self-assigned this Sep 25, 2023
@johnstcn johnstcn requested review from mafredri and mtojek September 26, 2023 16:34
@johnstcn johnstcn marked this pull request as ready for review September 26, 2023 16:34
mafredri
mafredri approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only read through it (no testing), but it looks good!

@johnstcn johnstcn merged commit 399b428 into main Sep 27, 2023
@johnstcn johnstcn deleted the cj/scaletest-tf-update branch September 27, 2023 08:02
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

@mtojek mtojek Awaiting requested review from mtojek

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnstcn @mafredri