Skip to content

feat: add … to actions that require confirmation #9862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 25, 2023
Merged

feat: add … to actions that require confirmation #9862

merged 6 commits into from
Sep 25, 2023

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Sep 25, 2023

took a quick tour around the app, adding … where appropriate as we've been talking about

Parkreiner
Parkreiner approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@Parkreiner Parkreiner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new ellipses all look to good to me! Also appreciate the apostrophe swaps, and the regex changes for the tests

@aslilac aslilac merged commit dac1375 into main Sep 25, 2023
@aslilac aslilac deleted the hellip branch September 25, 2023 21:25
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Parkreiner Parkreiner Parkreiner approved these changes

@BrunoQuaresma BrunoQuaresma Awaiting requested review from BrunoQuaresma

Assignees

@aslilac aslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aslilac @Parkreiner