chore: remove Maybe
#9880
Merged
chore: remove Maybe
#9880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parkreiner
approved these changes
Sep 26, 2023
| @@ -97,58 +96,65 @@ export const SignInForm: FC<React.PropsWithChildren<SignInFormProps>> = ({ | |||
| <h1 className={styles.title}> | |||
| Sign in to <strong>Coder</strong> | |||
| </h1> | |||
| <Maybe condition={error !== undefined}> | |||
|
|
|||
| {Boolean(error) && ( | |||
There was a problem hiding this comment.
They're subtle changes, but I'm a big fan of you changing the conditions to catch any falsey value, instead of undefined, especially with the errors being of type unknown
Kira-Pilot
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Thanks for taking this on! I'd love your thoughts on our <Cond /> component.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Y'know, maybe it's time to get rid of
Maybe