Skip to content

chore(dogfood): use coder modules in dogfood #9890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 30, 2023
Merged

chore(dogfood): use coder modules in dogfood #9890

merged 4 commits into from
Sep 30, 2023

Conversation

matifali
Copy link
Member

@matifali matifali commented Sep 27, 2023 •
edited
Loading

updates dogfood to use coder modules

Generated summary (powered by Graphite)

TL;DR

This pull request removes the dotfiles_url and jetbrains_ide parameters, and the related code from the main.tf file. It also adds several new modules for dotfiles, git-clone, personalize, code-server, jetbrains_gateway, vscode, and filebrowser. The startup_script has been updated to remove the installation and launch of filebrowser and the dotfiles related code.

What changed

  • Removed dotfiles_url and jetbrains_ide parameters.
  • Removed related code for dotfiles_url and jetbrains_ide.
  • Added new modules for dotfiles, git-clone, personalize, code-server, jetbrains_gateway, vscode, and filebrowser.
  • Updated startup_script to remove the installation and launch of filebrowser and the dotfiles related code.

How to test

  1. Go to https://dev.coder.com/templates/coder/versions/dazzling_hugle0 and create a new workspace or change your dogfood workspace version to dazzling_hugle0 .
  2. Verify that the new modules are working as expected.

Why make this change

The dotfiles_url and jetbrains_ide parameters and related code were removed to simplify the configuration and make it easier to manage. The new modules were added to provide additional functionality and improve the overall user experience. The startup_script was updated to reflect these changes.

@matifali matifali requested a review from kylecarbs September 27, 2023 14:42
@matifali matifali changed the title chore: use modules in dofgood chore: update dogfood to use coder modules Sep 27, 2023
@matifali matifali requested a review from bpmct September 27, 2023 19:03
matifali
matifali commented Sep 27, 2023
View reviewed changes
@matifali matifali changed the title chore: update dogfood to use coder modules chore(dogfood): update to use coder modules Sep 28, 2023
@matifali matifali changed the title chore(dogfood): update to use coder modules chore(dogfood): use coder modules in dogfood Sep 28, 2023
@matifali matifali requested review from mafredri and removed request for kylecarbs and bpmct September 28, 2023 12:34
mafredri
mafredri reviewed Sep 28, 2023
View reviewed changes
dogfood/main.tf

module "filebrowser" {
source = "https://registry.coder.com/modules/filebrowser"
agent_id = coder_agent.dev.id
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we set this to coder_agent.dev.dir? Same for code-server, etc. to match old behavior.

Copy link
Member Author

@matifali matifali Sep 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default, the file browser opens in $HOME. Adding your suggestion will open repo_dir. I think opening $HOME is more suitable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with keeping filebrowser in $HOME, but code-server used to open in the repo dir (and maybe vscode desktop too?).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vscode-desktop module currently does not support setting a folder so that it will prompt for a folder on launch. I wonder why @kylecarbs did this way.

Copy link
Member Author

@matifali matifali Sep 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code-server does have a folder variable that we can set to the repo_dir. I will update

@matifali matifali mentioned this pull request Sep 28, 2023
Merged
@matifali
Copy link
Member Author

@mafredri coder/modules#61

@matifali matifali requested a review from mafredri September 28, 2023 13:36
mafredri
mafredri approved these changes Sep 28, 2023
View reviewed changes
dogfood/main.tf

module "filebrowser" {
source = "https://registry.coder.com/modules/filebrowser"
agent_id = coder_agent.dev.id
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with keeping filebrowser in $HOME, but code-server used to open in the repo dir (and maybe vscode desktop too?).

ammario
ammario reviewed Sep 28, 2023
View reviewed changes
Copy link
Member

@ammario ammario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing Graphite. Ignore this review.

@matifali matifali mentioned this pull request Sep 29, 2023
Open
9 tasks
@matifali matifali merged commit 16a2d4d into main Sep 30, 2023
@matifali matifali deleted the dogfood-modules branch September 30, 2023 19:22
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ammario ammario ammario left review comments

@mafredri mafredri mafredri approved these changes

Assignees

@matifali matifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matifali @mafredri @ammario