-
Notifications
You must be signed in to change notification settings - Fork 887
refactor: start using emotion for styling #9909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Notes so far:
|
</ErrorBoundary> | ||
</ThemeProvider> | ||
<MuiThemeProvider theme={dark}> | ||
<EmotionThemeProvider theme={dark}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need both? Or is it only for the transition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, we can't get rid of MuiThemeProvider
as long as we use MUI, and making Emotion aware of the theme has some nice DX upsides, so this is gonna persist for a while.
Part of #9924
We're starting with 157 usages of
makeStyles
across 154 files. This changes brings that down to 143 usages across 140 files.Initial impressions are good!