Skip to content

feat(scaletest/dashboard): integrate chromedp #9927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 2, 2023
Merged

feat(scaletest/dashboard): integrate chromedp #9927

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a8fc106
fix(scaletest/harness): fix div-zero error
johnstcn Sep 28, 2023
d4ceee7
feat(scaletest/dashboard): add chromedp actions
johnstcn Sep 28, 2023
0ae372d
feat(cli): integrate chromedp actions into scaletest dashboard
johnstcn Sep 28, 2023
5c07be6
feat(scaletest/dashboard): remove unused code
johnstcn Sep 28, 2023
6aa0a52
rm unused flag
johnstcn Sep 29, 2023
41f7bb8
validate and fail-fast
johnstcn Sep 29, 2023
89bf0ee
fixup! validate and fail-fast
johnstcn Sep 29, 2023
48a319c
fixup! validate and fail-fast
johnstcn Sep 29, 2023
cca6a0b
log error on removing temp user data dir
johnstcn Sep 29, 2023
cf10151
use prng, add --rand-seed argument
johnstcn Sep 29, 2023
0805f2e
replace --min-wait and --max-wait with --interval and --jitter
johnstcn Sep 29, 2023
3232a92
Merge remote-tracking branch 'origin/main' into cj/scaletest-dashboar…
johnstcn Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
log error on removing temp user data dir
  • Loading branch information
@johnstcn
johnstcn committed Sep 29, 2023
commit cca6a0bcdb5477e4207f3fc2fc1e88b55db82267
8 changes: 6 additions & 2 deletions scaletest/dashboard/chromedp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ import (
"github.com/chromedp/cdproto/network"
"github.com/chromedp/chromedp"
"golang.org/x/xerrors"

"cdr.dev/slog"
)

// Action is just a function that does something.
Expand Down Expand Up @@ -150,7 +152,7 @@ func clickAndWait(ctx context.Context, clickOn, waitFor Selector) error {
// initChromeDPCtx initializes a chromedp context with the given session token cookie
//
//nolint:revive // yes, headless is a control flag
func initChromeDPCtx(ctx context.Context, u *url.URL, sessionToken string, headless bool) (context.Context, context.CancelFunc, error) {
func initChromeDPCtx(ctx context.Context, log slog.Logger, u *url.URL, sessionToken string, headless bool) (context.Context, context.CancelFunc, error) {
dir, err := os.MkdirTemp("", "scaletest-dashboard-*")
if err != nil {
return nil, nil, err
Expand All @@ -170,7 +172,9 @@ func initChromeDPCtx(ctx context.Context, u *url.URL, sessionToken string, headl
cancelFunc := func() {
cdpCancel()
allocCtxCancel()
_ = os.RemoveAll(dir)
if err := os.RemoveAll(dir); err != nil {
log.Error(ctx, "failed to remove temp user data dir", slog.F("dir", dir), slog.Error(err))
}
}

// set cookies
Expand Down
2 changes: 1 addition & 1 deletion scaletest/dashboard/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ func (r *Runner) Run(ctx context.Context, _ string, _ io.Writer) error {
return xerrors.Errorf("user has no organizations")
}

cdpCtx, cdpCancel, err := initChromeDPCtx(ctx, r.client.URL, r.client.SessionToken(), r.cfg.Headless)
cdpCtx, cdpCancel, err := initChromeDPCtx(ctx, r.cfg.Logger, r.client.URL, r.client.SessionToken(), r.cfg.Headless)
if err != nil {
return xerrors.Errorf("init chromedp ctx: %w", err)
}
Expand Down