Skip to content

test: fix flaky TestCreateValidateRichParameters/ValidateString #9928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2023
Merged

test: fix flaky TestCreateValidateRichParameters/ValidateString #9928

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: flaky TestCreateValidateRichParameters/ValidateString
  • Loading branch information
@mtojek
mtojek committed Sep 29, 2023
commit 262809ed8109aaae8fcb4eada3d5f55c4435eb09
9 changes: 6 additions & 3 deletions cli/create_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,9 @@ func TestCreateValidateRichParameters(t *testing.T) {
match := matches[i]
value := matches[i+1]
pty.ExpectMatch(match)
pty.WriteLine(value)
if value != "" {
pty.WriteLine(value)
}
}
<-doneChan
})
Expand Down Expand Up @@ -481,7 +483,6 @@ func TestCreateValidateRichParameters(t *testing.T) {
match := matches[i]
value := matches[i+1]
pty.ExpectMatch(match)

if value != "" {
pty.WriteLine(value)
}
Expand Down Expand Up @@ -519,7 +520,9 @@ func TestCreateValidateRichParameters(t *testing.T) {
match := matches[i]
value := matches[i+1]
pty.ExpectMatch(match)
pty.WriteLine(value)
if value != "" {
pty.WriteLine(value)
}
}
<-doneChan
})
Expand Down