Skip to content

fix(cli): remove exp scaletest from slim binary #9934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 3, 2023
Merged

fix(cli): remove exp scaletest from slim binary #9934

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0abd25b
fix(cli): remove exp scaletest from slim binary
johnstcn Sep 29, 2023
ead423e
fetch full coder binary
johnstcn Oct 3, 2023
dc5ee10
fixup! fetch full coder binary
johnstcn Oct 3, 2023
a31a2d3
fix namespace read
johnstcn Oct 3, 2023
d964de2
fix maybedryrun invocation, add more logging
johnstcn Oct 3, 2023
1095cc8
idempotency
johnstcn Oct 3, 2023
0618cbc
store binary under known unique stable path
johnstcn Oct 3, 2023
2b78246
work around kubectl foible
johnstcn Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix namespace read
  • Loading branch information
@johnstcn
johnstcn committed Oct 3, 2023
commit a31a2d37b94f8f3dcc05eef629209acbbb3a7381
4 changes: 2 additions & 2 deletions scaletest/templates/scaletest-runner/scripts/lib.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,8 +257,8 @@ fetch_coder_full() {
target_path="${target_dir}/coder"
local pod
local namespace
namespace=<(/var/run/secrets/kubernetes.io/serviceaccount/namespace)
if [[ -z ${namespace} ]]; then
namespace=$(</var/run/secrets/kubernetes.io/serviceaccount/namespace)
if [[ -z "${namespace}" ]]; then
log "Could not determine namespace!"
exit 1
fi
Expand Down