Skip to content

chore: rename git_auth to external_auth in our schema #9935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Sep 29, 2023
Merged

chore: rename git_auth to external_auth in our schema #9935

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
62185c6
chore: rename `git_auth` to `external_auth` in our schema
kylecarbs Sep 29, 2023
4709a54
Fix names
kylecarbs Sep 29, 2023
0f581ff
Fix outdated view
kylecarbs Sep 29, 2023
76f70ad
Rename some additional places
kylecarbs Sep 29, 2023
5e98a1d
Fix sort order
kylecarbs Sep 29, 2023
a3aabe1
Fix template versions auth route
kylecarbs Sep 29, 2023
13ffd77
Fix types
kylecarbs Sep 29, 2023
4789226
Fix dbauthz
kylecarbs Sep 29, 2023
81269f5
Fix names
kylecarbs Sep 29, 2023
e891ca5
More renames
kylecarbs Sep 29, 2023
7e447a5
Fix gen
kylecarbs Sep 29, 2023
d57e91f
Fix test
kylecarbs Sep 29, 2023
1d11cd9
Fix syntax error
kylecarbs Sep 29, 2023
9f2cb2a
Fix test
kylecarbs Sep 29, 2023
063d50b
Another syntax error
kylecarbs Sep 29, 2023
e2862fc
Fix migrations
kylecarbs Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test
  • Loading branch information
@kylecarbs
kylecarbs committed Sep 29, 2023
commit 9f2cb2a59c730096f72111e0b5949ef933d7397b
2 changes: 1 addition & 1 deletion coderd/provisionerdserver/provisionerdserver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1038,7 +1038,7 @@ func (s *server) CompleteJob(ctx context.Context, completed *proto.CompletedJob)
}
if !contains {
completedError = sql.NullString{
String: fmt.Sprintf("external provider %q is not configured", externalAuthProvider),
String: fmt.Sprintf("external auth provider %q is not configured", externalAuthProvider),
Valid: true,
}
break
Expand Down
2 changes: 1 addition & 1 deletion coderd/provisionerdserver/provisionerdserver_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -933,7 +933,7 @@ func TestCompleteJob(t *testing.T) {
completeJob()
job, err = db.GetProvisionerJobByID(ctx, job.ID)
require.NoError(t, err)
require.Contains(t, job.Error.String, `git auth provider "github" is not configured`)
require.Contains(t, job.Error.String, `external auth provider "github" is not configured`)
})

t.Run("TemplateImport_WithGitAuth", func(t *testing.T) {
Expand Down