Skip to content

feat(site): add support for weekly data on template insights #9997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Oct 3, 2023
Merged

feat(site): add support for weekly data on template insights #9997

merged 20 commits into from
Oct 3, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

Close #9495

@BrunoQuaresma BrunoQuaresma requested a review from a team October 2, 2023 17:50
@BrunoQuaresma BrunoQuaresma self-assigned this Oct 2, 2023
@BrunoQuaresma BrunoQuaresma requested review from aslilac and removed request for a team October 2, 2023 17:50
@BrunoQuaresma
Copy link
Collaborator Author

After taking a look at the PR I'm going to:

  • Move the queries to their modules
  • Maybe use the search params to store the filter state

@mtojek mtojek self-requested a review October 3, 2023 06:27
mtojek
mtojek previously requested changes Oct 3, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's block it for now until we sort out the backend's slow response time.

@BrunoQuaresma BrunoQuaresma requested a review from mtojek October 3, 2023 16:55
@BrunoQuaresma BrunoQuaresma dismissed mtojek’s stale review October 3, 2023 16:55

not a blocker anymore

aslilac
aslilac approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor things. Main thing is that I'm wondering if there's a nicer way to manage the daily and weekly state together, rather than keeping all of it so manual and separate.

BrunoQuaresma and others added 4 commits October 3, 2023 14:27
@BrunoQuaresma @aslilac
Update site/src/pages/TemplatePage/TemplateInsightsPage/IntervalMenu.tsx
68b1067 
Co-authored-by: Kayla Washburn <mckayla@hey.com>
@BrunoQuaresma @aslilac
Update site/src/pages/TemplatePage/TemplateInsightsPage/TemplateInsig…
8a8453c 
…htsPage.tsx

Co-authored-by: Kayla Washburn <mckayla@hey.com>
@BrunoQuaresma @aslilac
Update site/src/pages/TemplatePage/TemplateInsightsPage/WeeklyPresets…
44f640b 
…Menu.tsx

Co-authored-by: Kayla Washburn <mckayla@hey.com>
@BrunoQuaresma
Apply Kayla improvement
579b093
@BrunoQuaresma BrunoQuaresma merged commit bdb9954 into main Oct 3, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/support-weekly branch October 3, 2023 18:14
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Parkreiner Parkreiner Parkreiner left review comments

@aslilac aslilac aslilac approved these changes

@mtojek mtojek Awaiting requested review from mtojek

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Insights: Show weekly active users instead of daily
4 participants
@BrunoQuaresma @aslilac @mtojek @Parkreiner