Skip to content

fix: only allow promoting successful template versions #9998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 5, 2023
Merged

fix: only allow promoting successful template versions #9998

merged 11 commits into from
Oct 5, 2023

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Oct 2, 2023 •
edited
Loading

Closes #9904

  • Add a check on the backend to prevent promoting an invalid version which has a failed/canceled/unfinished build
  • Disable the "promote" button on the frontend to match
  • Add "failed", "canceling", "building", and "pending" badges in the UI for versions with corresponding states
  • Avoid showing the "newest" badge on versions that aren't valid
  • Hide "canceled" versions from the UI entirely

@aslilac aslilac requested a review from BrunoQuaresma October 2, 2023 18:45
@aslilac

This comment was marked as resolved.

Sign in to view
@aslilac aslilac force-pushed the only-promote-successful-builds branch from 70e9cd6 to 6dc8fc3 Compare October 2, 2023 23:23
BrunoQuaresma
BrunoQuaresma reviewed Oct 3, 2023
View reviewed changes
BrunoQuaresma
BrunoQuaresma reviewed Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE code looks good but since most of the changes are related to Go, I would also request a review from someone with more expertise on that

@aslilac aslilac requested a review from matifali October 3, 2023 22:58
spikecurtis
spikecurtis reviewed Oct 4, 2023
View reviewed changes
@aslilac aslilac requested a review from spikecurtis October 4, 2023 16:41
@aslilac aslilac merged commit f001a57 into main Oct 5, 2023
@aslilac aslilac deleted the only-promote-successful-builds branch October 5, 2023 16:49
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma left review comments

@spikecurtis spikecurtis spikecurtis approved these changes

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

@matifali matifali Awaiting requested review from matifali

Assignees

@aslilac aslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

do not allow promotion of a failed template version
3 participants
@aslilac @BrunoQuaresma @spikecurtis