-
Notifications
You must be signed in to change notification settings - Fork 2
chore: add handler and router for coder
scheme URIs
#145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coder-Desktop/Resources/1024.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is attached to the coder
scheme.
I've run into the same issue described in #98, but with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a handler and router to process coder
scheme URIs while updating the project dependency configuration and deep link handling. Key changes include:
- Adding the URLRouting package to the project configuration.
- Implementing a new router in VPNLib to parse and match coder URLs.
- Incorporating tests for various routing scenarios and updating deep link handling in the app delegate.
Reviewed Changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
Coder-Desktop/project.yml | Added URLRouting package dependency and updated targets. |
Coder-Desktop/VPNLibTests/CoderRouterTests.swift | Introduced comprehensive tests for the new router implementation. |
Coder-Desktop/VPNLib/CoderRouter.swift | Implemented the router and its associated types for coder URIs. |
Coder-Desktop/Coder-Desktop/URLHandler.swift | Added a URL handler to process matching coder URLs with error handling. |
Coder-Desktop/Coder-Desktop/Coder_DesktopApp.swift | Updated deep link handling by integrating the new URL handler. |
Files not reviewed (3)
- Coder-Desktop/Coder-Desktop/Info.plist: Language not supported
- Makefile: Language not supported
- scripts/build.sh: Language not supported
Relates to #96.
Closes #95