Skip to content

fix(pkgbuild): dont start coder connect after upgrade #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions pkgbuild/scripts/postinstall
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#!/usr/bin/env bash

RUNNING_MARKER_FILE="/tmp/coder_desktop_running"
VPN_MARKER_FILE="/tmp/coder_vpn_was_running"

# Before this script, or the user, opens the app, make sure
# Gatekeeper has ingested the notarization ticket.
Expand All @@ -19,14 +18,4 @@ if [ -f "$RUNNING_MARKER_FILE" ]; then
echo "Coder Desktop started."
fi

# Restart VPN if it was running before
if [ -f "$VPN_MARKER_FILE" ]; then
echo "Restarting CoderVPN..."
echo "Sleeping for 3..."
sleep 3
scutil --nc start "$(scutil --nc list | grep "com.coder.Coder-Desktop" | awk -F'"' '{print $2}')"
rm "$VPN_MARKER_FILE"
echo "CoderVPN started."
fi

exit 0
6 changes: 1 addition & 5 deletions pkgbuild/scripts/preinstall
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
#!/usr/bin/env bash

RUNNING_MARKER_FILE="/tmp/coder_desktop_running"
VPN_MARKER_FILE="/tmp/coder_vpn_was_running"

rm $VPN_MARKER_FILE $RUNNING_MARKER_FILE || true
rm $RUNNING_MARKER_FILE || true

if pgrep 'Coder Desktop'; then
touch $RUNNING_MARKER_FILE
Expand All @@ -14,9 +13,6 @@ vpn_name=$(scutil --nc list | grep "com.coder.Coder-Desktop" | awk -F'"' '{print
echo "Turning off VPN"
if [[ -n "$vpn_name" ]]; then
echo "CoderVPN found. Stopping..."
if scutil --nc status "$vpn_name" | grep -q "^Connected$"; then
touch $VPN_MARKER_FILE
fi
scutil --nc stop "$vpn_name"

# Wait for VPN to be disconnected
Expand Down
Loading