Skip to content

feat: make workspace app icons smaller, neater #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented May 7, 2025

sixicons.mov

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ethanndickson ethanndickson requested a review from matifali May 7, 2025 06:18
@ethanndickson ethanndickson marked this pull request as ready for review May 7, 2025 06:18
@ethanndickson
Copy link
Member Author

ethanndickson commented May 7, 2025

The Windsurf icon is still the old one due to some pretty aggressive caching by the SVG library we use. If it becomes an issue we can reduce the TTL, but I think it's fine for now.

EDIT: The default is 1 week https://github.com/SDWebImage/SDWebImage/blob/cac9a55a3ae92478a2c95042dcc8d9695d2129ca/SDWebImage/Core/SDImageCacheConfig.m#L14

Copy link
Member Author

ethanndickson commented May 7, 2025

Merge activity

  • May 7, 2:29 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • May 7, 2:29 AM EDT: @ethanndickson merged this pull request with Graphite.

@ethanndickson ethanndickson merged commit 79b0f7c into main May 7, 2025
4 checks passed
@ethanndickson ethanndickson deleted the ethan/smaller-app-icons branch May 7, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants