Skip to content

fix: handle missing workspace app display_name #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 9, 2025
Merged

fix: handle missing workspace app display_name #154

merged 2 commits into from
May 9, 2025
+6 −6

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented May 8, 2025 •
edited
Loading

also uses code-insiders.svg for the VS Code insiders icon.

Context: coder/coder#17700

@ethanndickson Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ethanndickson ethanndickson requested a review from deansheather May 8, 2025 04:24
@ethanndickson ethanndickson marked this pull request as ready for review May 8, 2025 04:24
@ethanndickson Graphite App
Copy link
Member Author

ethanndickson commented May 9, 2025 •
edited
Loading

Merge activity

  • May 8, 9:56 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • May 8, 9:56 PM EDT: @ethanndickson merged this pull request with Graphite.

@ethanndickson ethanndickson merged commit 49fd303 into main May 9, 2025
4 checks passed
@ethanndickson ethanndickson deleted the ethan/optional-display-name branch May 9, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deansheather deansheather deansheather approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanndickson @deansheather