chore: minor ui/ux changes #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deansheather
approved these changes
Jun 18, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR enhances UI/UX tooltips, improves error diagnostics for downloads, and standardizes sizing for file sync table controls.
- Adds hover tooltips on the copy DNS and open-in-browser tray menu buttons.
- Includes the download URL in
DownloadError.unexpectedStatusCodemessages. - Increases footer icon size from 24px to 30px via a new
FooterIconcomponent andTheme.Size.tableFooterIconSize.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| VPNLib/Download.swift | Updated DownloadError.unexpectedStatusCode to include URL and adjusted error resume call. |
| Views/VPN/VPNMenuItem.swift | Added .help(...) modifiers to show tooltips on hover for copy and open buttons. |
| Views/FileSync/FileSyncConfig.swift | Replaced fixed 24px frames with FooterIcon, increased size to 30px, and updated padding. |
| Theme.swift | Added Theme.Size.tableFooterIconSize to centralize the new footer icon dimension. |
Comments suppressed due to low confidence (4)
Coder-Desktop/VPNLib/Download.swift:149
- Consider adding a unit test that triggers an unexpected status code and asserts that the error description includes both the HTTP code and the download URL.
case unexpectedStatusCode(Int, url: String)
Coder-Desktop/VPNLib/Download.swift:149
- [nitpick] It may be safer to store the URL as a
URLtype instead ofStringin the error, preserving type information and avoiding downstream parsing issues.
case unexpectedStatusCode(Int, url: String)
Coder-Desktop/Coder-Desktop/Views/FileSync/FileSyncConfig.swift:149
- The play/pause toggle logic appears inverted: when
isResumableis true (i.e., the session is paused), you should show a play icon with tooltip "Resume", and vice versa for pausing.
FooterIcon(systemName: "play")
Coder-Desktop/Coder-Desktop/Views/FileSync/FileSyncConfig.swift:206
- [nitpick] If
FooterIconis intended for reuse across multiple views, consider moving it into a shared UI components file or adding a doc comment to clarify its purpose.
struct FooterIcon: View {
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes were in response to feedback: