fix(Makefile): add version validation checks #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2c83e83 to
1af2771
Compare
…ersion strings Change-Id: I83265a11182df6d28f2ef3a5f5454adba27c95ea Signed-off-by: Thomas Kosiewski <tk@coder.com>
1af2771 to
9370b0a
Compare
ethanndickson
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds validation for version variables in Makefile
Ensures CURRENT_PROJECT_VERSION and MARKETING_VERSION are not empty when building the project, failing the build process with an error message if either variable cannot be determined from git tags.
Change-Id: I83265a11182df6d28f2ef3a5f5454adba27c95ea
Signed-off-by: Thomas Kosiewski tk@coder.com