feat: add homebrew cask release action #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5e831ab to
38b2cd2
Compare
matifali
reviewed
Feb 14, 2025
b1c132d to
28b526e
Compare
Closed
2 tasks
matifali
reviewed
Feb 14, 2025
01e1524 to
a59b015
Compare
matifali
previously approved these changes
Feb 14, 2025
a59b015 to
352c6e1
Compare
matifali
approved these changes
Feb 18, 2025
Change-Id: I6e76a8fa519f378cda92b4edffa64c17294e01b9 Signed-off-by: Thomas Kosiewski <tk@coder.com>
352c6e1 to
f9ba5a1
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
nit: since we're gonna do preview builds off main we should probably call this build.yml & name: build.
| @@ -11,12 +11,12 @@ XCPROJECT := Coder\ Desktop/Coder\ Desktop.xcodeproj | |||
| SCHEME := Coder\ Desktop | |||
| SWIFT_VERSION := 6.0 | |||
|
|
|||
| CURRENT_PROJECT_VERSION=$(shell git describe --tags) | |||
| CURRENT_PROJECT_VERSION:=$(shell git describe --match 'v[0-9]*' --dirty='.devel' --always --tags) | |||
There was a problem hiding this comment.
I had to look this up but = is lazy, := is eager - do we need eager here?
There was a problem hiding this comment.
It's more about not reevaluating the value assignment.
A simple = will result in continuous re-expansions of the variable.
A :=, on the other hand, will only be expanded once and then used as a "constant".
(https://www.gnu.org/software/make/manual/html_node/Simple-Assignment.html)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds homebrew cask auto-update workflow and improves VPN logging
This change adds a new workflow to automatically update the homebrew cask when
a new version of Coder Desktop is released. It also improves VPN logging by
adding more debug logs and making the logger static, to avoid race conditions.
Change-Id: I6e76a8fa519f378cda92b4edffa64c17294e01b9
Signed-off-by: Thomas Kosiewski tk@coder.com