feat: added icon to installer's bootstrap application #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deansheather
approved these changes
May 30, 2025
| @@ -119,6 +119,9 @@ public class BootstrapperOptions : SharedOptions | |||
| [Option('w', "windows-app-sdk-path", Required = true, HelpText = "Path to the Windows App Sdk package to embed")] | |||
| public string WindowsAppSdkPath { get; set; } | |||
|
|
|||
| [Option('t', "theme-xml-path", Required = false, HelpText = "Path to the theme .xml file to use for the installer")] | |||
| public string ThemeXmlPath { get; set; } | |||
There was a problem hiding this comment.
Should be string? if it's nullable
There was a problem hiding this comment.
Nope. This construct doesn't exist in .NET 4.8.1. Boxed type only applies to int, double, etc. ie string is explicitly nullable in that .NET version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #38
WiX 5 introduced a bug that stopped respecting the icon file on the theme's Window. This is described in this issue: wixtoolset/issues#8104
This PR introduces:
build-bootstrapperto allow optional setting of thetheme xml,RtfLargeTheme.xmlfrom WiX5.0.2with the added attribute ofIconFile