Skip to content

fix: avoid build errors in CI #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2025
Merged

fix: avoid build errors in CI #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff392f0
fix: avoid build errors in CI
deansheather Jun 3, 2025
9e6ed3f
Update ci.yaml
deansheather Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
cache: true
cache-dependency-path: '**/packages.lock.json'
- name: dotnet restore
run: dotnet restore --locked-mode
run: dotnet restore --locked-mode /p:BuildWithNetFrameworkHostedCompiler=true
- name: dotnet format
run: dotnet format --verify-no-changes --no-restore

Expand Down Expand Up @@ -75,7 +75,7 @@ jobs:
cache: true
cache-dependency-path: '**/packages.lock.json'
- name: dotnet restore
run: dotnet restore --locked-mode
run: dotnet restore --locked-mode /p:BuildWithNetFrameworkHostedCompiler=true
# This doesn't call `dotnet publish` on the entire solution, just the
# projects we care about building. Doing a full publish includes test
# libraries and stuff which is pointless.
Expand Down
2 changes: 1 addition & 1 deletion scripts/Publish.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ if (Test-Path $buildPath) {
New-Item -ItemType Directory -Path $buildPath -Force

# Build in release mode
& dotnet.exe restore
& dotnet.exe restore /p:BuildWithNetFrameworkHostedCompiler=true
if ($LASTEXITCODE -ne 0) { throw "Failed to dotnet restore" }
$servicePublishDir = Join-Path $buildPath "service"
& dotnet.exe publish .\Vpn.Service\Vpn.Service.csproj -c Release -a $arch -o $servicePublishDir /p:Version=$version
Expand Down
Loading