feat: add support for RDP URIs #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3115c93 to
5378529
Compare
deansheather
reviewed
May 6, 2025
Comment on lines
+18
to
+21
| Serilog.Log.Logger = new LoggerConfiguration().MinimumLevel.Debug().WriteTo.NUnitOutput().CreateLogger(); | ||
| var builder = Host.CreateApplicationBuilder(); | ||
| builder.Services.AddSerilog(); | ||
| var logger = (ILogger<UriHandler>)builder.Build().Services.GetService(typeof(ILogger<UriHandler>))!; |
There was a problem hiding this comment.
Creating an application builder for this seems excessive as it's only being used to create ILogger instances. Is there no way to just get an ILogger from serilog and pass that through without using application hosting?
There was a problem hiding this comment.
If there is, I haven't figured it out.
deansheather
approved these changes
May 8, 2025
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds basic support for
coder:/URIs for opening RDP.relates to #52 but I still need to add support for checking the authority.