This repository was archived by the owner on Nov 14, 2024. It is now read-only.
address comments from #11 #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Clubhouse Story #15962: Checks for required cluster API resources. |
jawnsy
approved these changes
Sep 13, 2021
Makefile
Outdated
| @@ -33,5 +33,5 @@ test: test/go | |||
|
|
|||
| test/go: | |||
| @echo "--- go test" | |||
| go test -parallel=$(shell nproc) ./... | |||
| $(shell scripts/test_go.sh) | |||
There was a problem hiding this comment.
I think we can just do ./scripts/test_go.sh here, right?
There was a problem hiding this comment.
Whoops, yes that's correct!
| run_trace false goveralls -service=github -coverprofile="$COVERAGE" | ||
| set -e | ||
| # Skip coveralls if not running in CI | ||
| if [[ -n "${CI}" ]]; then |
There was a problem hiding this comment.
ah, yeah. We don't use this script to run local tests in the monorepo, which is why we didn't need that check there 🤷♂️
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses comments from #11