Skip to content
This repository was archived by the owner on Nov 14, 2024. It is now read-only.

add add'l instructions to install #34

Merged
merged 1 commit into from
Sep 21, 2021
Merged

add add'l instructions to install #34

merged 1 commit into from
Sep 21, 2021

Conversation

khorne3
Copy link
Contributor

@khorne3 khorne3 commented Sep 21, 2021

Added a bit of detail to streamline the process a bit; feel free to remove anything you think is unnecessary!

@khorne3 khorne3 requested a review from johnstcn September 21, 2021 14:29
@khorne3
Copy link
Contributor Author

khorne3 commented Sep 21, 2021

I added execute perms to the binary, but I forgot to check if it's actually required before doing so: chmod u+x coder-doctor. @johnstcn do you know if this is necessary or not?

Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@johnstcn
Copy link
Member

I added execute perms to the binary, but I forgot to check if it's actually required before doing so: chmod u+x coder-doctor. @johnstcn do you know if this is necessary or not?

I don't believe this is necessary; last I checked the permissions on the built binary include the executable bit by default.

@khorne3 khorne3 merged commit 489bddd into main Sep 21, 2021
@khorne3 khorne3 deleted the khorne3-patch-1 branch September 21, 2021 14:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants