Skip to content
This repository was archived by the owner on Nov 14, 2024. It is now read-only.

chore: check for common misspellings #38

Merged
merged 1 commit into from
Sep 22, 2021
Merged

chore: check for common misspellings #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@ linters-settings:
- pkg: k8s.io/metrics/pkg/apis/metrics/(v[\w\d]+)
alias: metrics${1}

misspell:
locale: US

revive:
# see https://github.com/mgechev/revive#available-rules for details.
ignore-generated-header: true
Expand Down Expand Up @@ -162,6 +165,7 @@ linters:
- importas
- ineffassign
- makezero
- misspell
- noctx
- revive
- rowserrcheck
Expand Down
2 changes: 1 addition & 1 deletion internal/checks/kube/rbac.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ func (k *KubernetesChecker) checkRBACDefault(ctx context.Context) ([]*api.CheckR
k.log.Debug(ctx, "Got SSRR PolicyRule", slog.F("rule", r))
}

// TODO: optimise this
// TODO: optimize this
for req, reqVerbs := range k.reqs.ResourceRequirements {
if err := satisfies(req, reqVerbs, compactRules); err != nil {
summary := fmt.Sprintf("resource %s: %s", req.Resource, err)
Expand Down
2 changes: 1 addition & 1 deletion internal/checks/kube/resources_list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"cdr.dev/coder-doctor/internal/api"
)

// This is a list of all known Resource and/or RBAC requirements for each verison of Coder.
// This is a list of all known Resource and/or RBAC requirements for each version of Coder.
// Order by version DESCENDING.
var allRequirements = []VersionedResourceRequirements{
{
Expand Down