Skip to content
This repository was archived by the owner on Nov 14, 2024. It is now read-only.

chore: improve text output for resource check #41

Merged
merged 2 commits into from
Sep 23, 2021
Merged

chore: improve text output for resource check #41

merged 2 commits into from
Sep 23, 2021

Conversation

jawnsy
Copy link
Contributor

@jawnsy jawnsy commented Sep 23, 2021 •
edited
Loading

  • Remove the synthetic error and create a failed result manually
  • Add the resource, group, and groupVersion in Details, so that
    it will be included in JSON output

Output before:

$ go run . check kubernetes
🔔 kube context: "gke_coder-dev-1_us-central1-a_dev-4"
✓ Coder 1.21.0 supports Helm >=3.6.0
✓ Coder 1.21.0 supports Kubernetes 1.19.0 to 1.22.0 (server version 1.20.9-gke.701)
✓ found required resource:"persistentvolumeclaims" group:"" version:"v1"
✓ found required resource:"services" group:"" version:"v1"
✓ found required resource:"pods" group:"metrics.k8s.io" version:"metrics.k8s.io/v1beta1"
✓ found required resource:"serviceaccounts" group:"" version:"v1"
✓ found required resource:"deployments" group:"apps" version:"apps/v1"
✓ found required resource:"statefulsets" group:"apps" version:"apps/v1"
✓ found required resource:"roles" group:"rbac.authorization.k8s.io" version:"rbac.authorization.k8s.io/v1"
✓ found required resource:"events" group:"" version:"v1"
✓ found required resource:"pods" group:"" version:"v1"
✓ found required resource:"secrets" group:"" version:"v1"
✓ found required resource:"replicasets" group:"apps" version:"apps/v1"
✓ found required resource:"ingresses" group:"networking.k8s.io" version:"networking.k8s.io/v1"
✓ found required resource:"networkpolicies" group:"networking.k8s.io" version:"networking.k8s.io/v1"
✓ found required resource:"rolebindings" group:"rbac.authorization.k8s.io" version:"rbac.authorization.k8s.io/v1"
✓ found required resource:"storageclasses" group:"storage.k8s.io" version:"storage.k8s.io/v1"

Output after:

$ go run . check kubernetes
🔔 kube context: "gke_coder-dev-1_us-central1-a_dev-4"
✓ Coder 1.21.0 supports Helm >=3.6.0
✓ Coder 1.21.0 supports Kubernetes 1.19.0 to 1.22.0 (server version 1.20.9-gke.701)
✓ Cluster supports v1 resource serviceaccounts
✓ Cluster supports apps/v1 resource replicasets
✓ Cluster supports v1 resource persistentvolumeclaims
✓ Cluster supports v1 resource services
✓ Cluster supports apps/v1 resource statefulsets
✓ Cluster supports networking.k8s.io/v1 resource ingresses
✓ Cluster supports rbac.authorization.k8s.io/v1 resource rolebindings
✓ Cluster supports v1 resource pods
✓ Cluster supports v1 resource secrets
✓ Cluster supports apps/v1 resource deployments
✓ Cluster supports metrics.k8s.io/v1beta1 resource pods
✓ Cluster supports v1 resource events
✓ Cluster supports networking.k8s.io/v1 resource networkpolicies
✓ Cluster supports rbac.authorization.k8s.io/v1 resource roles
✓ Cluster supports storage.k8s.io/v1 resource storageclasses

@jawnsy
chore: improve text output for resource check
4edd92d 
* Remove the synthetic error and create a failed result manually
* Add the resource, group, and groupVersion in Details, so that
  it will be included in JSON output
@jawnsy jawnsy self-assigned this Sep 23, 2021
@coveralls
Copy link

coveralls commented Sep 23, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1265857637

  • 16 of 16 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 83.602%
Totals Coverage Status
Change from base Build 1263299739: 0.2%
Covered Lines: 571
Relevant Lines: 683
💛 - Coveralls

@jawnsy jawnsy marked this pull request as ready for review September 23, 2021 12:54
@jawnsy jawnsy requested a review from johnstcn September 23, 2021 12:54
johnstcn
johnstcn approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jawnsy jawnsy merged commit 4c634c0 into main Sep 23, 2021
@jawnsy jawnsy deleted the jawnsy/chore-update-resource-output branch September 23, 2021 13:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@johnstcn johnstcn johnstcn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jawnsy jawnsy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jawnsy @coveralls @johnstcn