This repository was archived by the owner on Nov 14, 2024. It is now read-only.
feat: check helm version #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
commented
Aug 18, 2021
| @@ -107,15 +115,34 @@ func run(cmd *cobra.Command, _ []string) error { | |||
| log = log.Leveled(slog.LevelDebug) | |||
| } | |||
|
|
|||
| checker := kube.NewKubernetesChecker( | |||
| log.Info(cmd.Context(), "kubernetes config:", | |||
There was a problem hiding this comment.
I also decided that this would be a useful feature. I put it at level INFO for the moment, but if you think it's better off as DEBUG then that's fine too.
|
[ch16262] |
|
This pull request has been linked to Clubhouse Story #16262: Check helm version. |
jawnsy
approved these changes
Aug 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
Localchecker type. Its purpose is to report issues relating to the current execution environment.A future addition might be a
Remotechecker type that performs similar actions over SSH.As a local check may be required for other environment types, added a new
api.CheckTargettype to distinguish when certain checks are applicable. The use case for this can be seen ininternal/cmd/check/kubernetes.go:131, where we useWithCheckTarget(api.CheckTargetKubernetes)to indicate toLocalCheckerthat the intent is to check a Kubernetes cluster.Any checks that are not applicable to the given check target should be skipped.