Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: coder/coder-jetbrains-toolbox
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.2.0
Choose a base ref
...
head repository: coder/coder-jetbrains-toolbox
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
  • 6 commits
  • 31 files changed
  • 3 contributors

Commits on Apr 25, 2025

  1. Changelog update - v0.2.0 (#96)

    Current pull request contains patched `CHANGELOG.md` file for the
    `v0.2.0` version.
    
    Co-authored-by: GitHub Action <action@github.com>
    github-actions[bot] and actions-user authored Apr 25, 2025
    Configuration menu
    Copy the full SHA
    a9cff15 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2025

  1. chore: remove ssh background config (#97)

    From my testing, Toolbox forwards through SSH (i.e. through Coder) a
    remote port associated with the IDE
    running in server mode, to localhost in order for the server (i.e. the
    remote IDE) to communicate with
    JBClient. Unlike with Gateway, Toolbox manages to reuse the SSH
    connection, and it doesn't open a separate
    one for port forwarding.
    
    From Gateway we inherited two ssh hostnames per each workspace, one for
    background connections that did not
    involve running IDEs. Coder discards the bg. connection from the
    collected metrics in order to
    avoid double counting. Since Toolbox manages to re-use the connection we
    don't need to worry
    about double counting.
    
    For this particular change, I deployed the latest Coder version with
    prometheus metrics and experiments
    enabled (i.e. --prometheus-enable --prometheus-collect-agent-stats
    --experiments=workspace-usage) and made the following experiment:
    
    1. Opened up Toolbox, logged into Coder. At this point:
    - agent_sessions_total and coderd_agentstats_session_count_jetbrains
    were missing from prometheus metrics
    - jetbrains session count from api/v2/deployment/stats showed 0
    
    2. Opened up a Workspace at which point Toolbox established the SSH
    connection:
    - agent_sessions_total and coderd_agentstats_session_count_jetbrains
    increased to 1
    - jetbrains session count from api/v2/deployment/stats increased to 1 as
    well
    
    3. Hit the install button on RustRover, everything stayed unchanged
    
    4. Open RustRover, nothing changes in the stats.
    fioan89 authored Apr 28, 2025
    Configuration menu
    Copy the full SHA
    970f4c5 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2025

  1. fix: rendering glitches when a Workspace is stopped (#102)

    … while an SSH connection is alive.
    
    Toolbox raises a class cast exception when Workspaces are stopped while
    the SSH connection is running. After the workspace was stopped Toolbox
    refused to show widget with some weird glitches on the screen.
    The fix in this case is to safely disconnect the SSH before sending the
    stop command to the workspace. The code will wait at most 10 seconds for
    the disconnect to happen, and only after that send the stop.
    
    - resolves #98
    fioan89 authored May 2, 2025
    Configuration menu
    Copy the full SHA
    9fdd99b View commit details
    Browse the repository at this point in the history
  2. fix: misleading "No workspaces yet" during manual authentication (#104)

    There is a brief moment between manual authentication and workspace
    poller initialization and execution where we see a "No workspaces yet"
    which is misleading. Instead, a loading indicator/message should be
    displayed.
    
    - resolves #103
    fioan89 authored May 2, 2025
    Configuration menu
    Copy the full SHA
    db08dfa View commit details
    Browse the repository at this point in the history

Commits on May 5, 2025

  1. fix: access the settings page for the auth. wizard (#105)

    The Settings menu is only available after we successfully authenticate.
    This can be somewhat problematic if we want to configure something like
    coder cli path, or certificate path before doing the authentication.
    
    A new "Settings" button at the bottom of the page can now access the
    Settings page. Toolbox is a bit inflexible with the API because:
    - I could not find a way to delimit or separate the Settings button from
    the Back and Sign In/Connect button
    - we can't put a button or anything else in the top right corner, the
    traditional place for a settings icon.
    
    - resolves #90
    fioan89 authored May 5, 2025
    Configuration menu
    Copy the full SHA
    97cd0f0 View commit details
    Browse the repository at this point in the history
  2. Changelog update - v0.2.1 (#107)

    Current pull request contains patched `CHANGELOG.md` file for the
    `v0.2.1` version.
    
    Co-authored-by: GitHub Action <action@github.com>
    github-actions[bot] and actions-user authored May 5, 2025
    Configuration menu
    Copy the full SHA
    6a96e98 View commit details
    Browse the repository at this point in the history
Loading