chore: add JetBrains auto-approval compliance linter #139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 JetBrains Auto-Approval Compliance Linter
This PR implements a comprehensive linting system to ensure compliance with JetBrains auto-approval requirements for Toolbox plugins.
📋 What's Included
1. JetBrains Compliance Check Script
scripts/jetbrains-compliance-check.sh
- Shell script for critical compliance checking2. Detekt Integration
build.gradle.kts
with reasonable defaults3. CI/CD Integration
.github/workflows/jetbrains-compliance.yml
4. Documentation
JETBRAINS_COMPLIANCE.md
- Comprehensive guide✅ Compliance Requirements Covered
Based on JetBrains team communication:
Forbidden (Critical Violations):
Allowed (With Guidance):
coroutineScope.launch
for concurrencyselect
,onTimeout
)CoderRemoteProvider#close()
🧪 Testing
Current Status:
$ ./scripts/jetbrains-compliance-check.sh ✅ No critical violations found! Your code appears to comply with JetBrains auto-approval requirements.
Code Quality:
🚀 Usage
Local Development:
CI/CD:
📝 Changes Made
build.gradle.kts
gradle/libs.versions.toml
with detekt version🔍 Review Notes
This ensures the plugin maintains JetBrains auto-approval status while providing helpful guidance to developers.
📊 Current Results
The current codebase shows:
RunnableActionDescription
interface usage (acceptable)Testing: ✅ Tested locally, compliance script passes
Documentation: ✅ Comprehensive docs included
CI/CD: ✅ GitHub Actions workflow ready
Breaking Changes: ❌ None - fully backward compatible