Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

Add input while waiting for oauth callback to allow ssh #107

Closed
creack opened this issue Aug 31, 2020 · 2 comments · Fixed by #124
Closed

Add input while waiting for oauth callback to allow ssh #107

creack opened this issue Aug 31, 2020 · 2 comments · Fixed by #124
Assignees
@creack
Labels
dx-team Issues that should be tackled by the dx-team enhancement New feature or request

Comments

@creack
Copy link
Contributor

creack commented Aug 31, 2020

Right now, the cli login expects a HTTP callback, so when working over ssh, need to manually copy/paste the link into a different terminal and curl it. Having a text input to do the copy/paste directly on the cli would help a lot. (That's how concourse handles it for instance).
To be clear, that would be in addition of what we have, not instead.
@creack creack added the enhancement New feature or request label Aug 31, 2020
@cmoog
Copy link
Contributor

cmoog commented Aug 31, 2020 •
edited
Loading

The current setup is definitely not good for browserless environments. Any thoughts on #1?

I think that may be what you're getting at.

@creack
Copy link
Contributor Author

creack commented Aug 31, 2020

I missed that, it is interesting indeed, but would be a much bigger change. Here, we can simply add something like go os.Stdin.Read() and call it a day.

#1 would indeed be a better user experience.

@creack creack mentioned this issue Sep 7, 2020
Merged
@wbobeirne wbobeirne added the dx-team Issues that should be tackled by the dx-team label Sep 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@creack creack

Labels
dx-team Issues that should be tackled by the dx-team enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Manual token input during login. coder/coder-v1-cli
3 participants
@creack @wbobeirne @cmoog