Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

standardize string concatenation vs sprintf #115

Closed
creack opened this issue Sep 5, 2020 · 1 comment
Closed

standardize string concatenation vs sprintf #115

creack opened this issue Sep 5, 2020 · 1 comment
Labels
enhancement New feature or request simple

Comments

@creack
Copy link
Contributor

creack commented Sep 5, 2020

When creating the api url, we have a mix of fmt.Sprintf("%s") and string concatenation. We should flatten this to be consistent across the codebase.

Ref: #113 (comment)

cc @tychoish
@creack creack added enhancement New feature or request simple labels Sep 5, 2020
@creack creack mentioned this issue Sep 5, 2020
Merged
@cmoog
Copy link
Contributor

cmoog commented Jan 12, 2021

This is getting stale, will reopen if it comes up again.

@cmoog cmoog closed this as completed Jan 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request simple
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@creack @cmoog